OF-2940: After database install, run database upgrade check #2679
Conversation
With this change, any database upgrade scripts that update the database content beyond what is in the database install script will be executed directly after the install scripts are executed.
|
Is there a scenario where this is possible? |
|
Yes, quite easily. You can have a plugin that has an install script that creates a database structure for, let's say, version 5, while update scripts exist for versions 1 through 10. We typically don't do this (we always make sure that our install script immediately creates 'the latest version' of the database structure) but I've seen third-party plugins that don't: those only have an initial install script, followed by multiple upgrade scripts. For those plugins, the plugin currently needs to be reloaded for the entire database upgrade to complete (until that's done, the installation reports success, but isn't actually using the latest version, which can get very confusing). With this change, that is no longer needed. |
|
Have you been able to test this? |
Not exhaustive, but I tested with a regular plugin and a plugin that had its install script install less then the upgrade scripts. |
With this change, any database upgrade scripts that update the database content beyond what is in the database install script will be executed directly after the install scripts are executed.
One side-effect of this approach is that under certain conditions, the 'success' message can be logged twice. I'm not bothered by that to much: