Skip to content

Add fallback validation for Safari 14.0 #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2025
Merged

Add fallback validation for Safari 14.0 #529

merged 3 commits into from
Jan 30, 2025

Conversation

AlexandrHoroshih
Copy link
Collaborator

@AlexandrHoroshih AlexandrHoroshih commented Jan 30, 2025 •
edited
Loading

fixes #528

image

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for farfetched canceled.

Name Link
🔨 Latest commit 5a28d32
🔍 Latest deploy log https://app.netlify.com/sites/farfetched/deploys/679b80a94677cc00087fc6be

@AlexandrHoroshih AlexandrHoroshih marked this pull request as ready for review January 30, 2025 13:38
@AlexandrHoroshih
Copy link
Collaborator Author

Code from this PR also works in Safari <= 14.0
image

igorkamyshev
igorkamyshev approved these changes Jan 30, 2025
View reviewed changes
Copy link
Owner

@igorkamyshev igorkamyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пиздец. Возражений не имею.

@igorkamyshev igorkamyshev merged commit 1f54e10 into master Jan 30, 2025
10 checks passed
@igorkamyshev igorkamyshev deleted the fix-safari-14-0-issue-with-url branch January 30, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorkamyshev igorkamyshev igorkamyshev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Farfetched does not work with Safari 14.0 and full URLs - Configuration Error
2 participants
@AlexandrHoroshih @igorkamyshev