Laborarium 2 #25
Open
Laborarium 2 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ava -> src/main/java/edu/kis/vh/nursery/DefaultCountingOutRhymer.java modified: src/main/java/edu/kis/vh/nursery/DefaultCountingOutRhymer.java modified: src/main/java/edu/kis/vh/nursery/FIFORhymer.java modified: src/main/java/edu/kis/vh/nursery/HanoiRhymer.java modified: src/main/java/edu/kis/vh/nursery/factory/DefaultRhymersFactory.java modified: src/main/java/edu/kis/vh/nursery/factory/Rhymersfactory.java modified: src/test/java/edu/kis/vh/nursery/RhymersDemo.java modified: src/test/java/edu/kis/vh/nursery/RhymersJUnitTest.java
with '#' will be ignored, and an empty message aborts the commit. On branch master Your branch is up to date with 'origin/master'. Changes to be committed: modified: src/main/java/edu/kis/vh/nursery/DefaultCountingOutRhymer.java modified: src/main/java/edu/kis/vh/nursery/FIFORhymer.java modified: src/main/java/edu/kis/vh/nursery/HanoiRhymer.java modified: src/main/java/edu/kis/vh/nursery/factory/DefaultRhymersFactory.java modified: src/main/java/edu/kis/vh/nursery/factory/Rhymersfactory.java modified: src/test/java/edu/kis/vh/nursery/RhymersDemo.java modified: src/test/java/edu/kis/vh/nursery/RhymersJUnitTest.java
kowallus
requested changes
Nov 12, 2018
|
|
||
| import edu.kis.vh.nursery.Generate; | ||
|
|
||
| public class IntArrayStack implements Generate { |
There was a problem hiding this comment.
IntArrayStack should have common interface with IntLinkedList not Default...Ryhmer.
| package edu.kis.vh.nursery; | ||
| import storage.IntLinkedList; | ||
|
|
||
| public class DefaultCountingOutRhymer implements Generate { |
There was a problem hiding this comment.
Extracting Interface for Rhymers was not the task. Is Generate commited?
|
|
||
| private IntLinkedList intLinkList = new IntLinkedList(); | ||
|
|
||
| public DefaultCountingOutRhymer(IntLinkedList intLinkList) { |
There was a problem hiding this comment.
Only IntLinkedList can be used here. The goal was to enable using IntArrayStack and IntLinkedList.
|
Waiting for requested changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.