Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.1.0 #35

Merged
merged 5 commits into from
Jan 17, 2025
Merged

V2.1.0 #35

merged 5 commits into from
Jan 17, 2025

Conversation

aleksnanevski
Copy link
Collaborator

@aleksnanevski aleksnanevski commented Jan 17, 2025

  • A new minor release to support Hierarchy Builder 1.8 and coq-fcsl-pcm v2.1.0
  • Added lemma for backward symbolic execution (bnd_vrf) in htt/model.v
  • Added makefiles to build packages (suggested by Karl Palmskog).

@aleksnanevski
Copy link
Collaborator Author

@palmskog Hi Karl. I implemented the changes that you recommended yesterday, I think. Before I merge, would you please mind checking if I did so correctly, and if the setup will correctly package the files.

@aleksnanevski aleksnanevski requested a review from clayrat January 17, 2025 12:45
Copy link
Contributor

@palmskog palmskog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but why remove Dune-related files? There is no harm in keeping them around, and it gives more options what do with the release, e.g., use Dune locally.

@aleksnanevski
Copy link
Collaborator Author

Hm, ok, I can try to put the dune back. The first few attempts to build have failed, so I erased the dune files because I was unsure as to how they work. The error ended up being elsewhere in the end.

@aleksnanevski aleksnanevski merged commit b6c4102 into master Jan 17, 2025
3 checks passed
@aleksnanevski
Copy link
Collaborator Author

@palmskog Hmm, I'm having a problem with using the package, and I wonder if it has to do with the change in the build. Once I install coq-htt-core and coq-htt, the system, for some reason, doesn't assign them logical names. So I can't import the files into other projects. The behavior is different in fcsl-pcm, which does receive a logical name. Have you experienced this before?

@palmskog
Copy link
Contributor

@aleksnanevski the only difference I can see is that the package build now uses -Q - all the files are getting installed and so on, and the files are there in user-contrib/htt after installation. For example, the following command works fine in both htt 2.0.1 and 2.1.0:

From htt Require Import quicksort options.

@aleksnanevski
Copy link
Collaborator Author

Yes, the problem was that I just didn't refresh the opam environment variables via eval $(opam env). Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants