Allow specifying sequences to clear as a list of ranges #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
commented
Jan 8, 2024
romac
commented
Jan 8, 2024
romac
force-pushed
the
romac/clear-cli-sequence-ranges
branch
from
6b7abd2 to
31f933e
Compare
ancazamfir
approved these changes
Jan 9, 2024
12 tasks
romac
added a commit
that referenced
this pull request
Jan 12, 2024
Closes: #3672 * Add list of sequence numbers to clear pending CLI * With sequences option only clear the packets from the specified chain and not counterparty * Fix clippy, add sequence test * Update guide template * Allow specifying sequences to clear as a list of ranges (#3756) * Allow specifying sequences to clear as a list of ranges * Make the ranges inclusive * Update guide templates * Add packet-sequences to the packet tx CLIs. * Align and wording * Update guide templates * Improve output of `query packet pending` command * Add integration test for clearing packets by sequence number ranges * Add changelog entry --------- Co-authored-by: Romain Ruetschi <romain@informal.systems>
romac
added a commit
that referenced
this pull request
Jan 12, 2024
* Add list of sequence numbers to clear pending CLI * With sequences option only clear the packets from the specified chain and not counterparty * Fix clippy, add sequence test * Update guide template * Allow specifying sequences to clear as a list of ranges (#3756) * Allow specifying sequences to clear as a list of ranges * Make the ranges inclusive * Update guide templates * Add packet-sequences to the packet tx CLIs. * Align and wording * Update guide templates * Improve output of `query packet pending` command * Add integration test for clearing packets by sequence number ranges * Add changelog entry --------- Co-authored-by: Romain Ruetschi <romain@informal.systems>
romac
added a commit
that referenced
this pull request
Jan 15, 2024
….x (#3772) * Remove unused code for encoding a `Packet` into a `Vec<abci::EventAttribute>` (#3769) * Add list of sequence numbers to clear pending CLI (#3751) * Add list of sequence numbers to clear pending CLI * With sequences option only clear the packets from the specified chain and not counterparty * Fix clippy, add sequence test * Update guide template * Allow specifying sequences to clear as a list of ranges (#3756) * Allow specifying sequences to clear as a list of ranges * Make the ranges inclusive * Update guide templates * Add packet-sequences to the packet tx CLIs. * Align and wording * Update guide templates * Improve output of `query packet pending` command * Add integration test for clearing packets by sequence number ranges * Add changelog entry --------- Co-authored-by: Romain Ruetschi <romain@informal.systems> * Fix clippy warnings --------- Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3672 for the description of the feature and the syntax.