Support for creating and updating ICS 08 WASM clients wrapping an ICS 07 Tendermint client

[romac]

Part of: #3951

Depends on: #3942

Manual testing instructions

1. Get simd with Wasm client support

From the root of the hermes repository, on this branch, run:

❯ nix shell '.#ibc-go-v7-wasm-simapp'
❯ which simd
/nix/store/3pp59wi249yd30dmr7hb49wbm9s19zci-simd-v7.3.0-wasm/bin/simd

Or build simd on this branch of ibc-go: https://github.com/cosmos/ibc-go/tree/08-wasm/release/v0.1.x%2Bibc-go-v7.3.x-wasmvm-v1.5.x

2. Setup two simd chains with Wasm support

Put this into ./gm.toml, update gaiad_binary to point to the simd binary we installed above, and update the path to the hermes binary:

[global]
home_dir             = "$HOME/.gm"
gaiad_binary         = "/nix/store/3pp59wi249yd30dmr7hb49wbm9s19zci-simd-v7.3.0-wasm/bin/simd"
extra_wallets        = 1
auto_maintain_config = true
add_to_hermes        = true

[global.hermes]
binary            = "$HOME/Informal/Code/hermes/target/debug/hermes"
config            = "$HOME/.hermes/config.toml"
log_level         = "debug"
telemetry_enabled = false
telemetry_host    = "127.0.0.1"
telemetry_port    = 3001

[ibc0-wasm]
ports_start_at = 27000

[ibc1-wasm]
ports_start_at = 28000

3. Create the chains and update their config

Create, then stop and re-initialize the chains:

❯ GM_TOML=./gm.toml gm start
❯ GM_TOML=./gm.toml gm stop
❯ GM_TOML=./gm.toml gm nuke

Update the config of the chain ibc0-wasm:

• Fetch the scripts from this Gist: https://gist.github.com/romac/80eddfd304ec03562badf23d9b43f892

• Run enable-was.py:

  $ p3 enable-wasm.py ~/.gm/ibc0-wasm/

• Or do it manually:

  • In ~/.gm/ibc0-wasm/config/config.toml, change max_body_bytes to 10001048576
  • In ~/.gm/ibc0-wasm/config/genesis.json, change:
    • max_deposit_period to 10s
    • voting_period to 10s
    • Add 08-wasm to the list of alloed clients in allowed_clients

@@ -246,8 +246,8 @@
             "amount": "10000000"
           }
         ],
-        "max_deposit_period": "172800s",
-        "voting_period": "172800s",
+        "max_deposit_period": "10s",
+        "voting_period": "10s",
         "quorum": "0.334000000000000000",
         "threshold": "0.500000000000000000",
         "veto_threshold": "0.334000000000000000",
@@ -276,6 +276,7 @@
           "allowed_clients": [
             "06-solomachine",
             "07-tendermint",
+            "08-wasm",
             "09-localhost"
           ]
         },

4. Start the chains

❯ GM_TOML=./gm.toml hermes config
❯ GM_TOML=./gm.toml hermes keys
❯ GM_TOML=./gm.toml gm start

5. Install the contract on chain

• Get a wallet address of the validator account for ibc0-wasm

❯ GM_TOML=./gm.toml gm keys ibc0-wasm
- address: cosmos15culynpgfdcfupl3f2yrzmav4t8hhpfalc2eu6
  name: validator
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A4qOppP8gT3fF/671w7qKBFllT0DTlzwawwZ9b2dx926"}'

• Run the install script from the Gist:

❯ python3 ./install-wasm.py ibc0-wasm tcp://localhost:27000 cosmos15culynpgfdcfupl3f2yrzmav4t8hhpfalc2eu6 tools/integration-test/fixtures/wasm/ibc_client_tendermint_cw.wasm

6. Create a Wasm client using Hermes

❯ cargo run -- create client --host-chain ibc0-wasm --reference-chain ibc1-wasm --wasm-checksum 08eb0025bc235c3114946ab5124ade365061c4529068dcae180357e819a7cb07
SUCCESS CreateClient(
    CreateClient(
        Attributes {
            client_id: ClientId(
                "08-wasm-0",
            ),
            client_type: Wasm,
            consensus_height: Height {
                revision: 0,
                height: 220,
            },
        },
    ),
)

7. Update the Wasm client using Hermes

❯ cargo run -- update client --host-chain ibc0-wasm --client 08-wasm-0
SUCCESS [
    UpdateClient(
        UpdateClient {
            common: Attributes {
                client_id: ClientId(
                    "08-wasm-0",
                ),
                client_type: Wasm,
                consensus_height: Height {
                    revision: 0,
                    height: 232,
                },
            },
            header: None,
        },
    ),
]

---

PR author checklist:

• Added changelog entry, using unclog.
• Added tests: integration (for Hermes) or unit/mock tests (for modules).
• Linked to GitHub issue.
• Updated code comments and documentation (e.g., docs/).
• Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

• Reviewed Files changed in the GitHub PR explorer.
• Manually tested (in case integration/unit/mock tests are absent).

[romac]

CI consistently fails with

Client refresh failed: error raised while updating client on chain ibc1: failed sending message to dst chain
Caused by:
gRPC call send_tx_simulate failed with status: status: Unknown, message: "recovered: IBC validation/execution context error: ICS02 Client error: other error: cannot convert into a Height type from string \0\0\0\0\0\0\0-: wasm contract call failed [cosmos/ibc-go/modules/light-clients/08-wasm/types/vm.go:156]

whereas the test goes through successfully locally on macOS.

I was able to reproduce the failure, though not consistently, by tweaking the trusting_period of the clients. I wonder if there is a race condition where the client expires after we have sent the UpdateClient message, which ends up triggering the error above within the Wasm contract? That said, in the test the clients are refreshed way before their trusting period, so this shouldn't come into play.

Interestingly, it's only the second client (B -> A) which fails to refresh, never the first one.

[romac]

Alright, increasing the trusting period on CI fixed it, no idea why though…

[ljoss17]

Looks great, thanks for this!!
I left a few nits and questions

[ljoss17]

Looks good to me!