-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(code): Allow applications to define their own configuration type #872
Draft
romac
wants to merge
11
commits into
main
Choose a base branch
from
romac/split-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 82.64% 81.99% -0.65%
==========================================
Files 187 189 +2
Lines 16088 16150 +62
==========================================
- Hits 13295 13242 -53
- Misses 2793 2908 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #852
This PR removes the global
malachite_config::Config
struct and instead lets applications define their own configuration type with only the settings they need, which can include some of the settings provided bymalachite_config
, e.g.ConsensusConfig
,DiscoveryConfig
, etc. Some of those are required, and are captured by the newNodeConfig
trait. This also enables applications to pick a configuration format other than TOML.To this end, the
Node
trait gains an additional abstract type member,Node::Config
, to be instantiated with the concrete configuration type.Most of the complexity in this PR was to adapt the CLI and the test framework to deal with the new abstract configuration type defined by the application via the
Node
trait instead of working with a concreteConfig
type.PR author checklist
For all contributors
For external contributors