Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add detailed contributing informations #875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romac
Copy link
Member

@romac romac commented Feb 26, 2025

Closes: #874


PR author checklist

For all contributors

For external contributors

@romac romac mentioned this pull request Feb 26, 2025
@romac romac force-pushed the romac/contributing branch from 04eaadd to 179fa2a Compare February 26, 2025 09:24
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (ad7350e) to head (179fa2a).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #875   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files         187      187           
  Lines       16088    16088           
=======================================
  Hits        13295    13295           
  Misses       2793     2793           
Flag Coverage Δ
integration 82.51% <ø> (ø)
mbt 8.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

cargo install cargo-nextest
```

6. **Fork and clone the repository**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We can just say "Clone the repo" and keep this step simpler. We would also replace 'USERNAME' with 'informalsystems' in the git clone command.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone cannot contribute if they do not fork and clone the repository, so I would probably leave those steps as is. I can add a note that if one just wants to play around with the code and not submit PRs directly, they can clone the repo directly and give the command.

For macOS:

```bash
brew install protobuf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to say which of the tests requires this dependency. Or is it 'cargo build' ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's for building the Malachite apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo test fails
2 participants