This repository has been archived by the owner on Feb 11, 2025. It is now read-only.
#[drink::test] macro #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
requested review from
deuszx
and removed request for
piotrMocz
deuszx
reviewed
Oct 20, 2023
deuszx
reviewed
Oct 20, 2023
deuszx
reviewed
Oct 20, 2023
deuszx
reviewed
Oct 20, 2023
deuszx
reviewed
Oct 20, 2023
# Conflicts: # examples/flipper/lib.rs
# Conflicts: # Cargo.toml
deuszx
reviewed
Oct 23, 2023
Comment on lines
+88
to
+102
| let args = ExecuteArgs { | ||
| manifest_path, | ||
| verbosity: Verbosity::Default, | ||
| build_mode: BuildMode::Release, | ||
| features: Features::default(), | ||
| network: Network::Online, | ||
| build_artifact: BuildArtifacts::All, | ||
| unstable_flags: UnstableFlags::default(), | ||
| optimization_passes: Some(OptimizationPasses::default()), | ||
| keep_debug_symbols: false, | ||
| lint: false, | ||
| output_type: OutputType::HumanReadable, | ||
| skip_wasm_validation: false, | ||
| target: Target::Wasm, | ||
| }; |
There was a problem hiding this comment.
I'm wondering - some of these params are definable in Cargo.toml - especially for the root package - and here we're "overwriting" them. That's probably fine since we are "optimising for drink!" but just something to be aware of.
deuszx
approved these changes
Oct 23, 2023
piotrMocz
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
In this PR we introduce
#[drink::test]macro. It builds contract(s) for a testcase, similarly to theink_e2e::test.Follow-up: Provide bundles for all built contracts to a testcase.