Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction History Store #16

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Transaction History Store #16

wants to merge 23 commits into from

Conversation

patche-v
Copy link
Contributor

Transaction History Store

@patche-v patche-v requested a review from djale1k January 21, 2020 09:54
@patche-v patche-v changed the title Transaction History Store Transaction History Store Insert Jan 21, 2020
@patche-v patche-v changed the title Transaction History Store Insert Transaction History Store Jan 21, 2020
FilipNikolovski
FilipNikolovski reviewed Jan 30, 2020
View reviewed changes
BankAccount/pkg/tests/transactionhistorystore_test.go Outdated
store := store.NewTransactionHistoryStoreModel(suite.Db)
var err error
var transact []*entities.TransactionHistory
for _, value := range suite.TransactionsP {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpatcev18 why do we need to iterate the transactions here?

transact, err = store.GetTransactionsById(value.UserId)

This will fetch transactions multiple times for the same user ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipNikolovski FilipNikolovski FilipNikolovski approved these changes

@djale1k djale1k Awaiting requested review from djale1k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patche-v @FilipNikolovski