account store #22
Closed
account store #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BankAccount/pkg/store/account.go
Outdated
| ) | ||
|
|
||
| type AccountStore interface { | ||
| InsertAccount(userId int, balance float64, currency string, createdAt time.Time, updatedAt time.Time) (*entities.Account, error) |
There was a problem hiding this comment.
@F1c1cA don't pass createdAt and updatedAt as arguments, create them inside the method.
…ns into account-store
…ns into account-store
…interns into account-store-test
…interns into account-store
BankAccount/pkg/store/account.go
Outdated
| type AccountStore interface { | ||
| InsertAccount(userId int, balance float64, currency string) (*entities.Account, error) | ||
| GetAccountsByUserId(userId int) ([]*entities.Account, error) | ||
| UpdateAccount(id int, userId int, balance float64, currency string, updatedAt time.Time) (*entities.Account, error) |
There was a problem hiding this comment.
@F1c1cA you can remove updatedAt as an argument here, since it's not used.
BankAccount/pkg/store/account.go
Outdated
| InsertAccount(userId int, balance float64, currency string) (*entities.Account, error) | ||
| GetAccountsByUserId(userId int) ([]*entities.Account, error) | ||
| UpdateAccount(id int, userId int, balance float64, currency string, updatedAt time.Time) (*entities.Account, error) | ||
| CloseAccount(id int, userId int, updatedAt time.Time) (*entities.Account, error) |
There was a problem hiding this comment.
@F1c1cA here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
account store functions