Skip to content

Commit d8af02c

Browse files
shajoezhuedelarua
andauthored
upversion r min version, and survial depednecies (#1408)
# Pull Request <!--- Replace `#nnn` with your issue link for reference. --> Fixes #1366 Co-authored-by: Emily de la Rua <emily.de_la_rua@contractors.roche.com>
1 parent 65a3fb0 commit d8af02c

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ URL: https://insightsengineering.github.io/tern/,
2424
https://github.com/insightsengineering/tern/
2525
BugReports: https://github.com/insightsengineering/tern/issues
2626
Depends:
27-
R (>= 3.6),
27+
R (>= 4.4.0),
2828
rtables (>= 0.6.11)
2929
Imports:
3030
broom (>= 0.5.4),
@@ -49,7 +49,7 @@ Imports:
4949
rlang (>= 1.1.0),
5050
scales (>= 1.2.0),
5151
stats,
52-
survival (>= 3.6-4),
52+
survival (>= 3.8-3),
5353
tibble (>= 2.0.0),
5454
tidyr (>= 0.8.3),
5555
utils

tests/testthat/_snaps/coxph.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
Code
5151
res
5252
Output
53-
[1] 1.0000000 1.0000000 0.9678110 0.3970066 0.3252267 0.5286392
53+
[1] 1.0000000 0.7521316 0.3858022
5454

5555
---
5656

tests/testthat/test-coxph.R

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,6 @@ testthat::test_that("estimate_coef works correctly", {
4545
})
4646

4747
testthat::test_that("try_car_anova works correctly", {
48-
testthat::skip_if(packageVersion("survival") >= "3.8-3",
49-
message = "Skip test is version is greater than 3.8-3, breaking change"
50-
)
51-
5248
mod <- survival::coxph(
5349
formula = survival::Surv(time = futime, event = fustat) ~ factor(rx) + survival::strata(ecog.ps),
5450
data = survival::ovarian

0 commit comments

Comments
 (0)