Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Insecure to RestoreOperationRequest #4

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

an-tex
Copy link
Contributor

@an-tex an-tex commented Mar 26, 2021

(and implicitly to RestoreOperationResponse)

I tried running ./regenerate.sh, it worked fine with regenerating the Insecure part in the model_restore_operation*.go and RestoreOperation*.md files but I also got a lot of other changes in other files e.g.

Progress float64 `json:"progress"`

to

Progress string `json:"progress"`

and new

import (
	"time"
)

fixes #3

@smiklosovic
Copy link
Collaborator

Yes, the regeneration does change some stuff in such a way that is incompatible with how we want to use it ... Automatic generation is not so automatic after all for us so we need to tweak some things manually and regeneration will change it back so we have to revert it how we want it to be.

Thanks, merging.

@smiklosovic smiklosovic merged commit e9de0a7 into instaclustr:master Mar 26, 2021
@an-tex
Copy link
Contributor Author

an-tex commented Apr 8, 2021

Hi @smiklosovic ,
do you plan to publish a new release to pkg.go.dev any time soon? Would love to get things going on the casskop side of things :)
Cheers

@smiklosovic
Copy link
Collaborator

hey @an-tex

I am looking at that website for the very first time, how does this work? We have never published there anything on our own (from Instaclustr).

Maybe @cscetbon knows more?

@an-tex
Copy link
Contributor Author

an-tex commented Apr 9, 2021

I am looking at that website for the very first time, how does this work? We have never published there anything on our own (from Instaclustr).

No idea either, I just know it's used in casskop as a dependency

Edit: There's doc about adding a package, even though I don't see that mentioned "request" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Insecure parameter missing in restore Request?
2 participants