best observability

internetofwater · Dec 10, 2024 · 77d49ed · 77d49ed
1 parent 6c82e0c
commit 77d49ed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/e2e_test.yml b/.github/workflows/e2e_test.yml
@@ -5,7 +5,7 @@ on:
   workflow_dispatch: # Allows manual triggering of the workflow
 
 jobs:
-  setup-docker-and-run:
+  setup-docker-and-test:
     runs-on: ubuntu-latest
 
     steps:
@@ -19,4 +19,10 @@ jobs:
 
       # Run the Python script that handles the build and execution
       - name: Launch Docker Stack and run tests
-        run: python3 main.py local && python3 main.py wait_for "http://localhost:9001/minio/health/live" && python3 main.py test
+        run: python3 main.py local
+
+      - name: Wait for minio
+        run: python3 main.py wait_for "http://localhost:9001/minio/health/live" 
+
+      - name: Run pytest
+        run: python3 main.py test
diff --git a/main.py b/main.py
@@ -129,6 +129,7 @@ def wait_for_response(url: str):
     docker stack does not support conditional waits and the dockerfile logic
     would be otherwise messy
     """
+    print("Waiting for response from " + url)
     TIMEOUT_SEC = 180
     counter = 0
     while True and counter < TIMEOUT_SEC: