Use default web application for CodeLens links #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-rsingh
approved these changes
Jul 2, 2024
|
Is the removal of the CSPCHD code necessary? Will it mean that if my external browser isn't already logged in to the server VS Code is working on I will now have to authenticate there to benefit from this VS Code extension feature? |
|
I think that adding the parameter doesn't add value because by default the SMP won't use it. IMO it's confusing for the user to see the parameter in the URL but have to log in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1392. I removed the
CSPCHDtoken fetching code because we should let the browser handle the cookies.