Skip to content

Handle stricter 1.94 type checking wrt Buffer vs Uint8Array #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Handle stricter 1.94 type checking wrt Buffer vs Uint8Array #1439

wants to merge 1 commit into from

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes type errors that show up on 1.94-Insider, which is expected out as Stable this week.

@isc-bsaviano
Copy link
Contributor

I don't think this type mangling is necessary. I bumped the version of our @types/node devDeprenency and that fixed the issue for me. I'll make that change as part of another PR that I will likely open tomorrow.

@gjsjohnmurray
Copy link
Contributor Author

OK, closing unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-bsaviano isc-bsaviano Awaiting requested review from isc-bsaviano isc-bsaviano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjsjohnmurray @isc-bsaviano