From 8bddce585ccfe5762afca874cdabfc775e72f71b Mon Sep 17 00:00:00 2001
From: gjsjohnmurray <johnm@georgejames.com>
Date: Wed, 5 Feb 2025 13:28:32 +0000
Subject: [PATCH 1/2] Permit `Modify Server-side Workspace Folder...` before
 connection becomes active

---
 package.json                                  |  4 ++--
 src/commands/addServerNamespaceToWorkspace.ts | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/package.json b/package.json
index cc53a439..bb8e013c 100644
--- a/package.json
+++ b/package.json
@@ -297,7 +297,7 @@
         },
         {
           "command": "vscode-objectscript.modifyWsFolder",
-          "when": "vscode-objectscript.connectActive && workspaceFolderCount != 0"
+          "when": "workspaceFolderCount != 0"
         },
         {
           "command": "vscode-objectscript.openErrorLocation",
@@ -606,7 +606,7 @@
         },
         {
           "command": "vscode-objectscript.modifyWsFolder",
-          "when": "vscode-objectscript.connectActive && resourceScheme =~ /^isfs(-readonly)?$/ && explorerResourceIsRoot && !listMultiSelection",
+          "when": "explorerResourceIsRoot && !listMultiSelection",
           "group": "objectscript_modify@3"
         },
         {
diff --git a/src/commands/addServerNamespaceToWorkspace.ts b/src/commands/addServerNamespaceToWorkspace.ts
index e5f339e2..f243d919 100644
--- a/src/commands/addServerNamespaceToWorkspace.ts
+++ b/src/commands/addServerNamespaceToWorkspace.ts
@@ -397,13 +397,6 @@ export async function modifyWsFolder(wsFolderUri?: vscode.Uri): Promise<void> {
     if (!wsFolder) {
       return;
     }
-    if (notIsfs(wsFolder.uri)) {
-      vscode.window.showErrorMessage(
-        `Workspace folder '${wsFolder.name}' does not have scheme 'isfs' or 'isfs-readonly'.`,
-        "Dismiss"
-      );
-      return;
-    }
   } else {
     // Find the workspace folder for this uri
     wsFolder = vscode.workspace.getWorkspaceFolder(wsFolderUri);
@@ -411,6 +404,13 @@ export async function modifyWsFolder(wsFolderUri?: vscode.Uri): Promise<void> {
       return;
     }
   }
+  if (notIsfs(wsFolder.uri)) {
+    vscode.window.showErrorMessage(
+      `Workspace folder '${wsFolder.name}' does not have scheme 'isfs' or 'isfs-readonly'.`,
+      "Dismiss"
+    );
+    return;
+  }
 
   // Prompt the user to modify the uri
   const newUri = await modifyWsFolderUri(wsFolder.uri);

From a5ef7a7ef50358a2a5916ba137c04be7f5b62d99 Mon Sep 17 00:00:00 2001
From: gjsjohnmurray <johnm@georgejames.com>
Date: Wed, 5 Feb 2025 15:00:37 +0000
Subject: [PATCH 2/2] Improve the fix

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index bb8e013c..d595634e 100644
--- a/package.json
+++ b/package.json
@@ -606,7 +606,7 @@
         },
         {
           "command": "vscode-objectscript.modifyWsFolder",
-          "when": "explorerResourceIsRoot && !listMultiSelection",
+          "when": "(!resourceScheme || resourceScheme =~ /^isfs(-readonly)?$/) && explorerResourceIsRoot && !listMultiSelection",
           "group": "objectscript_modify@3"
         },
         {