From 1330568deffe09a89296415c4fdd295a1063e005 Mon Sep 17 00:00:00 2001 From: Yanni Pang Date: Tue, 13 May 2025 07:01:51 -0400 Subject: [PATCH 1/3] add error message on invalid api connection --- src/commands/xmlToUdl.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/commands/xmlToUdl.ts b/src/commands/xmlToUdl.ts index 7c6f3ba3..35c2ca95 100644 --- a/src/commands/xmlToUdl.ts +++ b/src/commands/xmlToUdl.ts @@ -13,7 +13,13 @@ export async function previewXMLAsUDL(textEditor: vscode.TextEditor, auto = fals if (notIsfs(uri) && uri.path.toLowerCase().endsWith("xml") && textEditor.document.lineCount > 2) { if (exportHeader.test(textEditor.document.lineAt(1).text)) { const api = new AtelierAPI(uri); - if (!api.active) return; + if (!api.active) { + vscode.window.showErrorMessage( + "Unsuccessful connection to the server. Please check your server connection settings.", + "Dismiss" + ); + return; + } try { // Convert the file const udlDocs: { name: string; content: string[] }[] = await api From 179693097f81a9b71fdf549bcd03e3107573ba07 Mon Sep 17 00:00:00 2001 From: yannip1234 Date: Wed, 14 May 2025 17:18:12 -0400 Subject: [PATCH 2/3] Update src/commands/xmlToUdl.ts Co-authored-by: Brett Saviano --- src/commands/xmlToUdl.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/xmlToUdl.ts b/src/commands/xmlToUdl.ts index 35c2ca95..7563b64e 100644 --- a/src/commands/xmlToUdl.ts +++ b/src/commands/xmlToUdl.ts @@ -15,7 +15,7 @@ export async function previewXMLAsUDL(textEditor: vscode.TextEditor, auto = fals const api = new AtelierAPI(uri); if (!api.active) { vscode.window.showErrorMessage( - "Unsuccessful connection to the server. Please check your server connection settings.", + "'Preview XML as UDL' command requires an active server connection.", "Dismiss" ); return; From f1c9721834d542892ddd5456f08cb4b33916b4b8 Mon Sep 17 00:00:00 2001 From: Yanni Pang Date: Wed, 14 May 2025 17:42:23 -0400 Subject: [PATCH 3/3] run lint-fix --- src/commands/xmlToUdl.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/commands/xmlToUdl.ts b/src/commands/xmlToUdl.ts index 7563b64e..fdb21bb7 100644 --- a/src/commands/xmlToUdl.ts +++ b/src/commands/xmlToUdl.ts @@ -14,10 +14,7 @@ export async function previewXMLAsUDL(textEditor: vscode.TextEditor, auto = fals if (exportHeader.test(textEditor.document.lineAt(1).text)) { const api = new AtelierAPI(uri); if (!api.active) { - vscode.window.showErrorMessage( - "'Preview XML as UDL' command requires an active server connection.", - "Dismiss" - ); + vscode.window.showErrorMessage("'Preview XML as UDL' command requires an active server connection.", "Dismiss"); return; } try {