Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init Alephium docs #370

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Init Alephium docs #370

merged 6 commits into from
Jul 17, 2024

Conversation

DevRozaDev
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
protocol ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 10:36am

Sniezka1927
Sniezka1927 requested changes Jul 12, 2024
View reviewed changes
@DevRozaDev
Copy link
Contributor Author

#370 (comment)

addressed all the comments except this one, pushed the current state to make further feedback easier to leave

wojciech-cichocki
wojciech-cichocki requested changes Jul 15, 2024
View reviewed changes
wojciech-cichocki
wojciech-cichocki requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lack of mention regarding the decimal types used and a rough introduction to U512 (how it is constructed, why such a decision was made)

@DevRozaDev
Copy link
Contributor Author

There is a lack of mention regarding the decimal types used and a rough introduction to U512 (how it is constructed, why such a decision was made)

We could add it in a separate PR unless it's necessary to have it in the initial version.

Sniezka1927

This comment was marked as resolved.

Sign in to view

Sniezka1927
Sniezka1927 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Sniezka1927 Sniezka1927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option abstraciton is not mentioned in the entrypoints section. I think may be worth to add it is own sub section.
Also it looks like it is not alligned with current protocol version. fee tiers are now static collection. If you like so you can apply these changes in the next pr

@DevRozaDev DevRozaDev merged commit c516b9a into master Jul 17, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-cichocki wojciech-cichocki wojciech-cichocki approved these changes

@Sniezka1927 Sniezka1927 Sniezka1927 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DevRozaDev @wojciech-cichocki @Sniezka1927