Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alph docs update #372

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Alph docs update #372

merged 4 commits into from
Jul 19, 2024

Conversation

DevRozaDev
Copy link
Contributor

No SDK or types yet
Update the rest to match current state up to PR#109

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
protocol ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 11:53am

mapping[U256, FeeTier] feeTiers
...
Contract Invariant(mut feeTiers: FeeTiers, feeTierCount: U256, ...){
const MaxFeeTiers = 32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing this constant variable might be redundant, FeeTiers struct is fixed size array so it is visible that the max fee tiers is 32. If you think it is better to keep it, then it can stay there.

@DevRozaDev DevRozaDev merged commit 305086d into master Jul 19, 2024
47 checks passed
@DevRozaDev DevRozaDev deleted the alph-docs-update branch July 19, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants