Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial jobs frontend #4

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented May 13, 2024

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

First commit is essentially the same as #3 + renaming of job -> jobs where we are referring to the feature as a whole/multiple jobs

Second commit fully integrates inveniosoftware/invenio-rdm-records#1747

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack carlinmack marked this pull request as draft May 13, 2024 12:00
@carlinmack carlinmack changed the title Jobs frontend initial jobs frontend May 13, 2024
@carlinmack carlinmack marked this pull request as ready for review May 13, 2024 13:52
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(Ping @wgresshoff : this PR seems to be doing some renames that could affect you.)

@slint slint merged commit be7174e into inveniosoftware:master May 13, 2024
4 checks passed
@carlinmack carlinmack linked an issue May 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs Administration UI
2 participants