[WIP] assets: re-structure assets and add webpack entries #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status with this one? Should it be integrated? |
|
It is pending an answer to the question stated on the PR description |
|
has this been solved? can it be closed? I see the master tests are passing but not sure whats the semantic/bootstrap status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109
Blocked by #124 (in order not to move files that will be changed...)
Problems and attempted solutions:
assets/bootstrap3assets/semantic-uistatic/Static should only contain static content (images, cmaps, locales) but no JS/CSS files. Those should go to the
assetsfolder. A first stab to this (adding the corresponding entry points in thewebpack.pyand changing imports was done.Questions
scssfolder (even in semantic-ui, where it should beless). Nonetheless, the content seems compatible with both. Could it go simply to the root? Or just duplicate and change file extension?