Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PREVIEWER_MAX_FILE_SIZE_BYTES does not apply to CSV files #190

Open
daglueck opened this issue Oct 11, 2023 · 1 comment · May be fixed by #191
Open

PREVIEWER_MAX_FILE_SIZE_BYTES does not apply to CSV files #190

daglueck opened this issue Oct 11, 2023 · 1 comment · May be fixed by #191

Comments

@daglueck
Copy link

daglueck commented Oct 11, 2023 •
edited
Loading

Package version (if known): v2.0.1

Describe the bug

The documentation for PREVIEWER_MAX_FILE_SIZE_BYTES mentions that it applies to CSV files (among others), but apparently there is no file size check happening in invenio_previewer.extensions.csv_papaparsejs.can_preview.

Steps to Reproduce

--

Expected behavior

Either the comment shouldn't say that it applies to CSV files or PREVIEWER_MAX_FILE_SIZE_BYTES should be applied to those files.

Screenshots (if applicable)

Additional context

Let me know in case you want me to open a PR for this.
@tmorrell
Copy link
Contributor

Ah, looks like that was missed on the new csv previewer. A PR that basically adds https://github.com/inveniosoftware/invenio-previewer/pull/185/files again would be welcome!

@daglueck daglueck linked a pull request Oct 12, 2023 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CSV max filesize check (#190) daglueck/invenio-previewer
2 participants
@tmorrell @daglueck