Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing tests due change in flask-resources #296

Closed
wants to merge 1 commit into from
Closed

fix: failing tests due change in flask-resources #296

wants to merge 1 commit into from

Conversation

utnapischtim
Copy link
Contributor

  • flask-resources v1.2.0 added links and sortby to the BaseListSchema

@utnapischtim
fix: failing tests due change in flask-resources
cd80e51 
* flask-resources v1.2.0 added links and sortby to the BaseListSchema
@utnapischtim utnapischtim mentioned this pull request Feb 11, 2024
Merged
10 tasks
@tmorrell tmorrell self-requested a review February 12, 2024 17:54
tmorrell
tmorrell approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks!

@lnielsen
Copy link
Member

Good to merge once tests are passing

@tmorrell
Copy link
Contributor

@utnapischtim can you fix the copyright line?

@utnapischtim
Copy link
Contributor Author

this has already bin fixed by Nicola two weeks ago

@utnapischtim utnapischtim deleted the fix-ci-tests branch March 19, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnielsen lnielsen lnielsen approved these changes

@tmorrell tmorrell tmorrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utnapischtim @lnielsen @tmorrell