contrib: Remove redundant fields from affiliations, funders search #460
+52
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmorrell
reviewed
Feb 12, 2025
| @@ -42,12 +42,9 @@ class AffiliationsSearchOptions(SearchOptions): | |||
| # Aliases can sometimes be shorter, so we boost them a bit. | |||
| "aliases^5", | |||
| localized_title, | |||
| "id^2", | |||
There was a problem hiding this comment.
I think this is going to break searching by ROR. The test data might be misleading here…in real data the id isn’t the same as the acronym.
There was a problem hiding this comment.
Maybe not because of identifiers…but could you add a test?
There was a problem hiding this comment.
Thanks! I've added a test, it works
tmorrell
reviewed
Feb 12, 2025
| # Allow to search identifiers directly (e.g. ROR) | ||
| "identifiers.identifier", | ||
| "country", |
There was a problem hiding this comment.
This might make it difficult to disambiguate funders with the same name but in different countries.
There was a problem hiding this comment.
So, the country is the abbreviation and the country_name is the full name of the country, which is what is shown in the UI too. I've also added a test for search with country.
sakshamarora1
force-pushed
the
fix/affiliations_funder_search
branch
from
5a974c0 to
872fe8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #459