Skip to content

Commit eed6223

Browse files
Fix default value for SESSION_COOKIE_SECURE (#8767) (#8769)
- Default value was previously 'True' - Documentation indicated that it was 'False' - Value in config_template.yaml was 'False' (but commented out) (cherry picked from commit d4ee8c5) Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
1 parent cab7a06 commit eed6223

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/backend/InvenTree/InvenTree/settings.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1218,7 +1218,9 @@
12181218
if DEBUG
12191219
else (
12201220
SESSION_COOKIE_SAMESITE == 'None'
1221-
or get_boolean_setting('INVENTREE_SESSION_COOKIE_SECURE', 'cookie.secure', True)
1221+
or get_boolean_setting(
1222+
'INVENTREE_SESSION_COOKIE_SECURE', 'cookie.secure', False
1223+
)
12221224
)
12231225
)
12241226

src/backend/InvenTree/config_template.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ use_x_forwarded_host: false
124124
use_x_forwarded_port: false
125125

126126
# Cookie settings (nominally the default settings should be fine)
127-
#cookie:
128-
# secure: false
129-
# samesite: false
127+
cookie:
128+
secure: false
129+
samesite: false
130130

131131
# Cross Origin Resource Sharing (CORS) settings (see https://github.com/adamchainz/django-cors-headers)
132132
cors:

0 commit comments

Comments
 (0)