Rulset simplification #9506
Open
Rulset simplification #9506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove 'stock_location' - Remove 'part_category'
SchrodingersGat
added
the
breaking
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SchrodingersGat
added a commit
to inventree/inventree-app
that referenced
this pull request
Apr 15, 2025
SchrodingersGat
added a commit
to inventree/inventree-app
that referenced
this pull request
Apr 15, 2025
|
This makes it such that anyone in an org that should work on parts also can mess up the general structure of the database as they now can also create/remove categories and locations. Can we hold of on merging this till the mentioned solution to use plugins for permissions is done? This would cause serious headaches in my instances, especially because I would have to patch permissions somehow as the default behavior changes. |
|
@matmair fair enough, I'll leave this one pending until we have a good solution for exposing to plugins. |
|
Maybe we can discuss the overall design shift before implementing it - for example in #7466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an effort towards improving / updating / reworking the "permissions" system (with the eventual goal of simplification and allowing plugins to hook into permission checks) - this PR consolidates some of the existing role types:
part_categoryrole - now inpartstock_locationrole - now instockReferences