-
-
Notifications
You must be signed in to change notification settings - Fork 947
Report merge #9532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Report merge #9532
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This reverts commit 00d80ba.
As the API schema is changed you will also need to change the API version - see https://docs.inventree.org/en/stable/develop/contributing/#api-versioning Let me know if you want more detailed pointers |
Is it just simply updating "src/backend/InvenTree/InvenTree/api_version.py" by bumping up the version and add a new line to INVENTREE_API_TEXT? |
Yes; Just copy the latest entry and adjust to fit this PR (especially the url) |
@tristanle22 a great start here :) Please begin by addressing the issues raised by @matmair |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good reduction of duplicates
Looks pretty good now; it mainly is missing the migration I mentioned above and a bit of unit-testing to ensure your changes continue to work in the future; |
@matmair For migration, there are some new Python files generated in |
Both correct @tristanle22 |
Is there a way to run |
https://docs.inventree.org/en/latest/develop/contributing/?h=dev.test#run-tests-locally In your case invoke dev.test -r report.tests |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9532 +/- ##
==========================================
+ Coverage 86.35% 86.36% +0.01%
==========================================
Files 1229 1230 +1
Lines 53966 54019 +53
Branches 2259 2259
==========================================
+ Hits 46601 46653 +52
- Misses 6793 6794 +1
Partials 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I setup this command in launch.json, but it doesn't stop at any breakpoints. I want to place breakpoints to play around with the variables to see how the pieces work together. Do you have any suggestions? |
There is a pre-defined launch definition for this provided in the code base, check out the launch.json file |
@tristanle22 looking good; could you resolve the merge conflict so we can do a final review round? |
Do I understand it correct, that now we have another "dimension" of possible context generation in a matrix. So now we have different contexts for:
=> 2 * (~9) * 2 = ~36 different context combinations Meaning if merge is set, all instance specific context is available in Just asking, because I have to adjust my LSP plugin accoringly now. |
Yes both correct |
… into report_merge
@SchrodingersGat @matmair I think it's ready for a final round of review. Let me know if there's anything else you'd like to add/updated! |
… into report_merge
… into report_merge
@tristanle22 I'm back from vacation now and ready to review. Can you please look at the conflicts here and I can review again :) |
Allow generation of a signle report PDF when multiple items are selected.
Closes #9423