Skip to content

feat(docs): add stable links for external sites #9620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025

Conversation

matmair
Copy link
Contributor

@matmair matmair commented May 2, 2025

This is useful for the CII best practices badge and other sites where we might need stable links; assuming we maintain control of docs.inventree.org seems like a good bet with current project structures.

this is usefull for the CII best practices badge and other sites where we might need stable links; assuming we maintain control of docs.inventree.org seems like a stable bet with current structures
@matmair matmair added this to the 1.0.0 milestone May 2, 2025
@matmair matmair self-assigned this May 2, 2025
@matmair matmair requested a review from SchrodingersGat as a code owner May 2, 2025 23:56
Copy link

netlify bot commented May 2, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 5dba389
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/68190db0feeef4000805006d

@matmair matmair changed the title add stable links for external docs add stable links for external sites May 2, 2025
@matmair
Copy link
Contributor Author

matmair commented May 2, 2025

This is required for example for https://www.bestpractices.dev/en/projects/7179 to ensure the links we provide are stable
part of #9525

@matmair matmair changed the title add stable links for external sites feat(docs): add stable links for external sites May 3, 2025
@matmair
Copy link
Contributor Author

matmair commented May 3, 2025

We seem to be hitting 429's on the GH api right now, might need to wait a bit

@SchrodingersGat
Copy link
Member

Looks like the 429s continue. Has something changed with the GitHub API limits?

@matmair
Copy link
Contributor Author

matmair commented May 5, 2025

@SchrodingersGat this is now good to go

@SchrodingersGat SchrodingersGat merged commit 6d0a08d into inventree:master May 5, 2025
23 checks passed
@SchrodingersGat SchrodingersGat deleted the stable-doc-links branch May 5, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants