feat(frontend): Improve barcode scanning text input on Platform UI. #9655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports part of 8059fb1 to Platform UI. Fixes inventree#7529.
Automatically submits 2D barcode scans when end of transmission character is input.
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SchrodingersGat
approved these changes
May 13, 2025
SchrodingersGat
added
enhancement
|
@willbicks thanks for the submission 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two improvements to barcode scanning via text input to Platform UI:
Adds control character handling to barcode text input (used to work in Classic UI).
I opted not to port alt-code handling because it seems like the old implementation assumes that your OS doesn't handle alt codes (e.g. works on MacOS, leads to double-inputs on Windows).
Submit barcode scan on EOT character.
This means that popular industrial barcode scanners (e.g. Zebra, Symbol, Motorola) can auto submit 2D barcodes even though they don't terminate scans with 'Enter' out of the box.