Skip to content

feat: add tax_id field to Company model and related forms #9673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sufyan-mukadam
Copy link

This PR adds Tax Id to the company model and UI as requested in #9622.

Does not close #9622 but takes it halfway to completion.

Copy link

netlify bot commented May 17, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 86fc770
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/682a0d94ee3dfb00086f108a

name="tax_id",
field=models.CharField(
blank=True,
help_text="Company Tax iD",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix capitalisation of this field (Company Tax ID)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, I've updated it now!

@SchrodingersGat
Copy link
Member

@sufyan-mukadam nice, clean implementation - just a simple typo to fix.

Please note that the "address" field already exists - so I think that this completes the linked issue,. yes?

@sufyan-mukadam
Copy link
Author

@SchrodingersGat Thanks for the feedback, this is my first contribution to an Open Source project!

That's true, in that case the issue can be marked completed now!

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature api Relates to the API User Interface Related to the frontend / User Interface labels May 18, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone May 18, 2025
@SchrodingersGat
Copy link
Member

As you have made a change to the API spec, you will need to add an entry in the "api_version.py" file - following the existing format.

Thanks for the contribution, we are very happy to receive PRs and assist new developers. Hopefully the first of many!

@sufyan-mukadam
Copy link
Author

@SchrodingersGat Thanks for guiding me through this, I have made the change to the "api_version.py" file. I hope that it is appropriate.

@SchrodingersGat
Copy link
Member

Nice work! Looks like one of the unit tests is failing due to an expected number of available fields. Let me know if you need any help tracking this down.

Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (3d71be3) to head (86fc770).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9673   +/-   ##
=======================================
  Coverage   86.35%   86.36%           
=======================================
  Files        1229     1230    +1     
  Lines       53966    53971    +5     
  Branches     2259     2259           
=======================================
+ Hits        46601    46610    +9     
+ Misses       6793     6789    -4     
  Partials      572      572           
Flag Coverage Δ
backend 88.32% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sufyan-mukadam
Copy link
Author

@SchrodingersGat, Thank you, I would like to try and resolve it first (still learning), if I get stuck I will request assistance if that's okay.

@sufyan-mukadam
Copy link
Author

@SchrodingersGat I have managed to fix the issue with unexpected fields but I can't figure out the [QC / Tests - Web UI (pull_request)] one, any guidance there would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Address & Tax ID
2 participants