-
-
Notifications
You must be signed in to change notification settings - Fork 938
feat: add tax_id field to Company model and related forms #9673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
name="tax_id", | ||
field=models.CharField( | ||
blank=True, | ||
help_text="Company Tax iD", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix capitalisation of this field (Company Tax ID)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that, I've updated it now!
@sufyan-mukadam nice, clean implementation - just a simple typo to fix. Please note that the "address" field already exists - so I think that this completes the linked issue,. yes? |
@SchrodingersGat Thanks for the feedback, this is my first contribution to an Open Source project! That's true, in that case the issue can be marked completed now! |
As you have made a change to the API spec, you will need to add an entry in the "api_version.py" file - following the existing format. Thanks for the contribution, we are very happy to receive PRs and assist new developers. Hopefully the first of many! |
@SchrodingersGat Thanks for guiding me through this, I have made the change to the "api_version.py" file. I hope that it is appropriate. |
Nice work! Looks like one of the unit tests is failing due to an expected number of available fields. Let me know if you need any help tracking this down. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9673 +/- ##
=======================================
Coverage 86.35% 86.36%
=======================================
Files 1229 1230 +1
Lines 53966 53971 +5
Branches 2259 2259
=======================================
+ Hits 46601 46610 +9
+ Misses 6793 6789 -4
Partials 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@SchrodingersGat, Thank you, I would like to try and resolve it first (still learning), if I get stuck I will request assistance if that's okay. |
@SchrodingersGat I have managed to fix the issue with unexpected fields but I can't figure out the |
This PR adds Tax Id to the company model and UI as requested in #9622.
Does not close #9622 but takes it halfway to completion.