Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to rebind named binding? #853

Open
akosyakov opened this issue Apr 18, 2018 · 4 comments
Open

How to rebind named binding? #853

akosyakov opened this issue Apr 18, 2018 · 4 comments

Comments

@akosyakov
Copy link

See https://github.com/theia-ide/theia/pull/1664/files#r182040835

@remojansen
Copy link
Member

@akosyakov seems like we need to implement rebindNamed and rebindTagged()?

@tonyhallett
Copy link
Contributor

See #447 for a solution

@tonyhallett
Copy link
Contributor

tonyhallett commented Aug 18, 2019

I would happily do a pull request.
Should the container have the method ?
Should the binding syntax be extended ?
container.bind(IThing).to(Thing) returns interface something like

interface UnbindRebind<T>{
unbind():void
rebind<T>:interfaces.BindingToSyntax<T>
rebindValue(newValue:any):void//or rebindTo/rebindToSelf
}

@tonyhallett
Copy link
Contributor

I have opted for extending the fluent syntax. I should hopefully have a pull request tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants