Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update restify types and fix tests #231

Merged
merged 2 commits into from
May 29, 2018
Merged

Conversation

mgebundy
Copy link

@mgebundy mgebundy commented May 29, 2018

Description

Update the tests so that they pass. Travis check doesn't fail when tests are failing (this PR doesn't fix that).

Added a types folder, because the @types/restify package isn't up to date with restify 7.2. I'll be submitting a PR over there with the changes soon.

Related Issue

inversify/InversifyJS#886

Motivation and Context

Fixed the tests so they pass and we can have confidence in using the package with the newest versions of restify and inversify.

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dcavanagh dcavanagh merged commit 88bb4a4 into inversify:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants