Skip to content

fix: Check for Pods/FirebaseCrashlytics directory when using SPM #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Gustl22
Copy link
Contributor

@Gustl22 Gustl22 commented Feb 18, 2025

…Pods simultaneously

Description

If using pods and SPM packages simultaneously the Pods folder still exists, but the script is in the SPM directory.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Feb 18, 2025
@Gustl22 Gustl22 changed the title fix: Check for Pods/FirebaseCrashlytics directory when using SPM and … fix: Check for Pods/FirebaseCrashlytics directory when using SPM and … Feb 18, 2025
@russellwheatley russellwheatley changed the title fix: Check for Pods/FirebaseCrashlytics directory when using SPM and … fix: Check for Pods/FirebaseCrashlytics directory when using SPM Feb 18, 2025
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this catch 🙏

@russellwheatley russellwheatley merged commit 7ef4ddd into invertase:main Feb 18, 2025
8 of 11 checks passed
@Gustl22
Copy link
Contributor Author

Gustl22 commented Mar 31, 2025

@russellwheatley any chance to get this fix published? Thank you for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention OP created or responded to issue and it needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants