Skip to content

fix: Check for Pods/FirebaseCrashlytics directory when using SPM #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: Check for Pods/FirebaseCrashlytics directory when using SPM #377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31c2227
fix: Check for Pods/FirebaseCrashlytics directory when using SPM and …
Gustl22 Feb 18, 2025
f64942f
Update firebase_apple_writes.dart
Gustl22 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/flutterfire_cli/lib/src/firebase/firebase_apple_writes.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ bashScript = %q(
#!/bin/bash
PATH="\${PATH}:\$FLUTTER_ROOT/bin:\$HOME/.pub-cache/bin"

if [ -z "\$PODS_ROOT" ]; then
if [ -z "\$PODS_ROOT" ] || [ ! -d "\$PODS_ROOT/FirebaseCrashlytics" ]; then
# Cannot use "BUILD_DIR%/Build/*" as per Firebase documentation, it points to "flutter-project/build/ios/*" path which doesn't have run script
DERIVED_DATA_PATH=\$(echo "\$BUILD_ROOT" | sed -E 's|(.*DerivedData/[^/]+).*|\\1|')
PATH_TO_CRASHLYTICS_UPLOAD_SCRIPT="\${DERIVED_DATA_PATH}/SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/run"
Expand Down
Loading