Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Update Messaging.md #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Messaging.md #172

wants to merge 1 commit into from

Conversation

abunsen
Copy link

@abunsen abunsen commented Mar 28, 2019

This is an attempt to clarify that React Native Firebase method: firebase.messaging().hasPermission() does not check with Firebase Cloud Messaging platform, but instead only checks the device permissions.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2019

CLA assistant check
All committers have signed the CLA.

@abunsen
Copy link
Author

abunsen commented Mar 28, 2019

@Salakar @Ehesp would love to bring some clarity to this issue.

Copy link

@SkarDude SkarDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

I just did a POC supporting this claim and it is true

@mikehardy
Copy link
Collaborator

I have a question about this, I get the point - the messaging check is local, but...is "cloud messaging permission" a thing? I didn't there was the concept of permissions at all at the cloud level, just per device?

If I understand that correctly then the messaging shouldn't be as if there were two possibilities and this only checks one, it should instead clarify that permissions only exists on the device and you have to check it.

It's subtle, but I wouldn't want an attempt to clarify things make it seem as if there was some other permissions scheme out there

Or am I missing an FCM cloud messaging permissions thing?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants