-
-
Notifications
You must be signed in to change notification settings - Fork 165
[🐛] Bug Report Title - EAS Android build issue 14.10.0 gma_ad_services_config.xml #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
i am experiencing the same issue |
Looks like I try to go back to |
same here |
Try 14.10.1 |
same here |
FYI - I had to go back to '14.9.0' to remove the error. |
Not sure if this is related but I also had to downgrade to get past this. At first on 14.10.1 I was getting this same error, then I commented out the gma_ad_services_config remove entry in my manifest and was getting a different error about Kotlin version incompatibility. It works for me again on 14.9.1, still without the gma_ad_services_config remove entry in my manifest |
We now have 14.11.0 released which reverts upgrading to Android SDK 24.1.0, as this requires kotlin 2.0.0 (a breaking change). |
Thanks @dylancom! Can confirm this fixed my issues and I'm able to build without the gma_ad_services_config remove entry in my manifest |
Android Manifest ad services config tools:remove stuffJust a note for people using v23 of play-services-ads SDK (which is what you'll get with the v14.x series here), as far as I understand:
As far as I know, the only factor determining whether you need it or not is if you use other packages which also include it (1 is fine, 2 or more cause a build error) Known collisions are So if you don't need it, fantastic! And with v24 of our native SDK / v15 version series here, you won't need it ever again which is nice But on v14 here / v23 of the native android SDK you might need that AndroidManifest trick, and no other person can tell you whether you will or not without looking at your package.json and maybe not even then if they don't know all those packages deeply... Accessing the new SDK if you wantMany thanks to Dylan for mopping up the inadvertent mess - a bit subtle of Google to slip in a binary-incompatible change with their compiler toolchain here. I will note for anyone that wants to use the new Android ads SDK v24, via the v15 release here, it only requires one patch to react-native's built-in android gradle plugin to be compatible with kotlin 2.1, and the patch applies via patch-package back to react-native 0.76 at least. The fix will aslo be in the react-native 0.79 release that's coming up soon as well, so v15+ here will be accessible in combination with react-native 0.79 as soon as it is out. Here's the patch until then - this is already on react-native main and release-0.79 branches upstream: |
@mikehardy Thank you so much for the fix! However, I cannot find it as it shows a 404 error page: |
@mikehardy found later that upgrading to 2.0.0 (instead of 2.1.0) is enough, which doesn't require a patch! See: https://docs.page/invertase/react-native-google-mobile-ads/migrating-to-v15 |
I would love some guidance on how to do it for |
@zguo123 I think you want https://docs.expo.dev/versions/latest/sdk/build-properties/, you set the kotlinVersion one (it's nested, you'll have to read the docs...) and an expo prebuild A success report and config file snippet if it works would probably be a huge help for future people! |
Thanks! I have installed Config:
{
....,
"expo-build-properties": "~0.13.2",
}
...
[
"expo-build-properties",
{
android: {
kotlinVersion: "2.0.0",
},
...
},
], Running
|
@zguo123 the hazards of attempting to troubleshoot without having a fully reproducible minimal example. I wonder if you are not on an outdated version of Expo though, they have definitely done "kotlin 2" compatibility work, see this https://github.com/expo/expo/pull/34500/files#diff-dcab4f253e7efe2ec641357ce996a56297c9b64ed9ef5ce4b2e7ae571263d8af It appears you may be on Expo SDK 51, and you need to be on SDK52 which I believe comes with kotlin 2+ by default |
(I don't use Expo though, so could be wrong about everything, if so, very sorry) |
@mikehardy Ah its aboslutely okay! i am using Expo version 52 and it is still not working. For now, I am downgrading to 14.11.0 and I will get an example working |
@zguo123 I would bring this up with Expo in an issue there - this seems like something that should work and you're pretty current. There must be some little trick missing somehow / someway I just don't know what |
@mikehardy thanks so much! I will troubleshoot as well |
found this comment: turns out you need react native 0.77 |
What happened?
EAS Android Build is failing:
FAILURE: Build failed with an exception.
Execution failed for task ':app:processDebugResources'.
I tried creating that file and copying it with EAS build pre install but still doesn't work:
"eas-build-pre-install": "npm config set legacy-peer-deps true && mkdir -p $PWD/android/app/src/main/res/xml && cp $PWD/gma_ad_services_config.xml $PWD/android/app/src/main/res/xml/gma_ad_services_config.xml"
Platforms
Android, but have not tested behavior on iOS
React Native Info
Are your using Typescript?
package.json
app.json
ios/Podfile
android/build.gradle
android/app/build.gradle
android/settings.gradle
AndroidManifest.xml
The text was updated successfully, but these errors were encountered: