Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh errors logged with level "debug" instead of "error" #190

Open
mcm1957 opened this issue Sep 30, 2022 · 3 comments
Open

ssh errors logged with level "debug" instead of "error" #190

mcm1957 opened this issue Sep 30, 2022 · 3 comments

Comments

@mcm1957
Copy link
Member

mcm1957 commented Sep 30, 2022

Describe the bug
Errors ocurring during ssh commands are not visible, they are logged with .debug level only.

synology.0 2022-09-30 17:42:03.905 warn System reboot
synology.0 2022-09-30 17:42:03.900 debug *** ERROR : src: SSH Error: code: undefined message: sudo: 1 incorrect password attempt
synology.0 2022-09-30 17:42:03.899 debug *** ERROR : src: SSH Error: code: undefined message: sudo: no password was provided
synology.0 2022-09-30 17:42:03.898 debug *** ERROR : src: SSH Error: code: undefined message: Sorry, try again.Password:

Expected behavior
I would expect to see above error with severity "error" (and not severiyt "debug".

Versions:

  • Adapter version: synology 2.1.9

DSM is 7.1, Command was "reboot"

Note:
The "function error" is a little bit confusing - it looks like every error is output as debug log if output at all:

   if (!~src.indexOf('getSongCover')){
        adapter.log.debug(`*** ERROR : src: ${src || 'unknown'} code: ${code} message: ${message}`);
    }
@mcm1957
Copy link
Member Author

mcm1957 commented Sep 30, 2022

The routine "fucntion error" is called by functions which regular raise errors, i.e. polling the audiostation at a system without such a package installed. So error handling must become smarter to ignore those errors (as it does now) but raise real errors such as ssh password errors etc.

Issue needs detailed analysis

@stale
Copy link

stale bot commented Dec 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix This will not be worked on label Dec 31, 2022
@mcm1957
Copy link
Member Author

mcm1957 commented Dec 31, 2022

Stil not solved

@stale stale bot removed the wontfix This will not be worked on label Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant