Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IPython.core.payloadpage to this package ? #1304

Closed
Carreau opened this issue Dec 11, 2024 · 2 comments · Fixed by #1317
Closed

Move IPython.core.payloadpage to this package ? #1304

Carreau opened this issue Dec 11, 2024 · 2 comments · Fixed by #1317
Milestone
7.0

Comments

@Carreau
Copy link
Member

Carreau commented Dec 11, 2024 

ipykernel/ipykernel/zmqshell.py
 23:from IPython.core import page, payloadpage
547:        self.set_hook("show_in_pager", page.as_hook(payloadpage.page), 99)

Seem to be the only thing that refer to IPython.core.payloadpage submodule, even in IPython itself;
so I think it should be moved here.
@minrk
Copy link
Member

minrk commented Dec 11, 2024

Makes sense.

@Carreau Carreau added this to the 7.0 milestone Feb 12, 2025
Carreau added a commit to Carreau/ipykernel that referenced this issue Feb 12, 2025
@Carreau
Copy payloadpage.page from IPython
8d062c2 
IPykernel is the only user, and this will let us remove it from IPython.

Closes ipython#1304
@Carreau Carreau mentioned this issue Feb 12, 2025
Merged
Carreau added a commit to Carreau/ipykernel that referenced this issue Feb 12, 2025
@Carreau
Copy payloadpage.page from IPython
3531972 
IPykernel is the only user, and this will let us remove it from IPython.

Closes ipython#1304
Carreau added a commit to Carreau/ipykernel that referenced this issue Feb 13, 2025
@Carreau
Copy payloadpage.page from IPython
98b4c3f 
IPykernel is the only user, and this will let us remove it from IPython.

Closes ipython#1304
@Carreau
Copy link
Member Author

Carreau commented Feb 13, 2025

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Copy payloadpage.page from IPython Carreau/ipykernel
2 participants
@minrk @Carreau