Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatch swallows test failures ? #1323

Open
Carreau opened this issue Feb 12, 2025 · 3 comments
Open

hatch swallows test failures ? #1323

Carreau opened this issue Feb 12, 2025 · 3 comments

Comments

@Carreau
Copy link
Member

Carreau commented Feb 12, 2025

It seem that hatch (or something else?) jus ignore some failure.

see this run of current main branch:

https://github.com/ipython/ipykernel/actions/runs/13286863326/job/37097508006 which is aborted,
and this comment:

#1322 (comment)

That point to a run with actual failures that appear as passing.

@davidbrochart
Copy link
Collaborator

It's because we rerun last failed tests here.

@Carreau
Copy link
Member Author

Carreau commented Feb 13, 2025

That seems wrong, it can hide test that modify global state and make subsequent test to fail.
Plus the abort I linked to does not seem to be reran.

@davidbrochart
Copy link
Collaborator

Plus the abort I linked to does not seem to be reran.

You mean this? https://github.com/ipython/ipykernel/actions/runs/13286863326/job/37097508006
Yes it is rerun (look for --lf).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants