Replace BaseThread's add_task with start_soon #1300
+70
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the PR with my latest changes in #1291. |
Carreau
reviewed
Feb 13, 2025
ipykernel/thread.py
Outdated
Comment on lines
46
to
49
| try: | ||
| run(self._main) | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
Do you want to at least log something if there is an exception ? It seems weird to me to swallow exception, but I'll trust you there.
There was a problem hiding this comment.
True, but I'm not sure if this would play well with threads like iostream, which does something with writing to stdout/stderr?
Maybe the exception could be made available through a method instead?
|
The lint errors have been fixed on main, and the other failures are the same as main, so +1 to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a
BaseThread'sadd_task()method withstart_soon(). The new name is less confusing as it's the same as in AnyIO, and it allows to start a task in the thread even after the thread has been started.We also get rid of
_IOPubThread, which has no reason to be different than aBaseThread.(from #1291)