make debugger class configurable #1307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
reviewed
Dec 13, 2024
jasongrout
reviewed
Dec 13, 2024
jasongrout
approved these changes
Dec 14, 2024
davidbrochart
approved these changes
Dec 16, 2024
krassowski
reviewed
Dec 16, 2024
There was a problem hiding this comment.
It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309
|
Can this get rebased to trigger CI (I try to do it, but there is no allow push from maintainers). |
smacke
force-pushed
the
smacke/configurable-debugger
branch
from
6bd5782 to
175f1dc
Compare
for more information, see https://pre-commit.ci
|
Hey @Carreau just rebased + pushed |
|
There is one minor lint to fix (unused mypy ignore), and I restarted the test on 3.9. I would actually be in favor of dropping 3.9 support (per https://scientific-python.org/specs/spec-0000/), and FYI IPython CLI already dropped 3.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, add fields
compiler_classanddebugger_classdefaulting to the normal types. Kernel subclasses can override these to provide additional customizations.