Try to fix unclosed resources. #1319
Open
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think these might be one of the few places that create those socket, so maybe closing them is the right call. I'm not sure. There are random failures on some tests. as _handle_pipe_msg is use in a single place and `self._async_pipe_in1` is used only to be passed between _handle_pipe_msgs and _handle_pipe_msg I'm tempted to refactor and pass _async_pipe_in1 as a parameter maybe ? and also rename to _handle_single_pipe_msg to make it visually a bit more distinctive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these might be one of the few places that create those socket, so maybe closing them is the right call. I'm not sure.
There are random failures on some tests.
as _handle_pipe_msg is use in a single place and
self._async_pipe_in1is used only to be passed between _handle_pipe_msgs and _handle_pipe_msg I'm tempted to refactor and pass _async_pipe_in1 as a parameter maybe ? and also rename to _handle_single_pipe_msg to make it visually a bit more distinctive.