Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete always skipped tests that used removed attributes, and unskip trio test #1322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Feb 12, 2025

There are few chances we will ever use them again.

Also a small refactor and unskip of trio test using trio nursery.

@Carreau Carreau force-pushed the del-always-skip branch 2 times, most recently from da04e6e to 48caeaa Compare February 12, 2025 18:38
@Carreau Carreau changed the title Delete always skipped tests that used removed attributes. Delete always skipped tests that used removed attributes, and unskip trio test Feb 12, 2025
@Carreau
Copy link
Member Author

Carreau commented Feb 12, 2025

Well that's strange, trio test passes locally...

well on CI, anyio decides to switch in the middle of the call stack from trio to asyncio:

    |     tg.start_soon(self.kernel.start)
      |   File ".../site-packages/anyio/_backends/_trio.py", line 191, in __aexit__
      |     return await self._nursery_manager.__aexit__(exc_type, exc_val, exc_tb)  # type: ignore[return-value]
      |   File ".../site-packages/trio/_core/_run.py", line 1043, in __aexit__
      |     raise combined_error_from_nursery
      | exceptiongroup.ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
      +-+---------------- 1 ----------------
        | Traceback (most recent call last):
        |   File ".../ipykernel/ipykernel/kernelapp.py", line 753, in _wait_to_enter_eventloop
        |     await self.kernel._eventloop_set.wait()
        |   File ".../site-packages/anyio/_core/_synchronization.py", line 139, in wait
        |     await self._event.wait()
        |   File ".../site-packages/anyio/_backends/_asyncio.py", line 1764, in wait
        |     await AsyncIOBackend.checkpoint()
        |   File ".../site-packages/anyio/_backends/_asyncio.py", 

@Carreau
Copy link
Member Author

Carreau commented Feb 12, 2025

Well something else is wrong on CI, some pytest items are failing, but it's shown as green on 3.10: https://github.com/ipython/ipykernel/actions/runs/13292836924/job/37117594041?pr=1322

@davidbrochart
Copy link
Collaborator

Well something else is wrong on CI, some pytest items are failing, but it's shown as green on 3.10: https://github.com/ipython/ipykernel/actions/runs/13292836924/job/37117594041?pr=1322

It's because we rerun last failed tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants