Don't rerun test with --lf #1324
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is an anti patern,
1) we are already using flaky, so flaky test should be marked as such.
2) if it fails on first run and pass on --lf, this indicate that the
test are relying on a global state that should either:
- be investigated
- is known, and then should be given a specific marker to be ran
separately.
The only advantage is to delay finding issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is an anti pattern,
we are already using flaky, so flaky test should be marked as such.
if it fails on first run and pass on --lf, this indicate that the
test are relying on a global state that should either:
The only advantage is to delay finding issues.
--
This is just a suggestion and my reasoning, I can be convince otherwise. See #1323, and thanks to @davidbrochart for pointing out that there was the --lf.