Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend support for handling more events from libvirt daemon #192

Open
3 tasks
lukas016 opened this issue Feb 19, 2024 · 0 comments
Open
3 tasks

extend support for handling more events from libvirt daemon #192

lukas016 opened this issue Feb 19, 2024 · 0 comments
Labels
enhancement New feature or request prio-low

Comments

@lukas016
Copy link
Contributor

Summary

current issue #177 integrate only basic event handler for lifecycle events. But libvirt daemon support more kind of events: https://pkg.go.dev/github.com/digitalocean/go-libvirt#DomainEventID

Minimally we will need to support these events: DomainEventIDDeviceRemoved, DomainEventIDDeviceAdded

But i prefer create general and easy extendable solution for handle all events which can be configurable with arguments.
How it will specific work, it will depend on implementation of issue.

Basic example

--machine-controller-libvirt-events=deviceRemoved,deviceAdded

or

--machine-controller-libvirt-events-exclude=metadataChange

Tasks

  • create design
  • present design
  • implement approved design

Motivation

Handling more libvirt daemon events easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio-low
Projects
Status: Todo
Development

No branches or pull requests

1 participant