Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added toggle keyboard feature #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added toggle keyboard feature #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b0af61
added toggle keyboard feature
Apr 9, 2014
aca5fbe
added vertical arrows shortcuts to keyboard navigation feature
Apr 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions jquery.bxslider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
stopText: 'Stop',
autoControlsCombine: false,
autoControlsSelector: null,
keyboardEnabled: false,

// AUTO
auto: false,
Expand Down Expand Up @@ -317,6 +318,8 @@
if (slider.settings.controls) updateDirectionControls();
// if touchEnabled is true, setup the touch events
if (slider.settings.touchEnabled && !slider.settings.ticker) initTouch();
// setup the keyboard events
setupKeyboard();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I setup the keyboard anyway on start, in case the user initializes the slider without the parameter 'keyboardEnabled' set to true, but later on decides to enable it. What do you think?

}

/**
Expand Down Expand Up @@ -1077,6 +1080,26 @@
}
}

/**
* Setup keyboard navigation
*/
var setupKeyboard = function(){
$(document).keydown(function(e){
if (e.keyCode == 39 && slider.settings.mode != 'vertical') {
if (slider.settings.keyboardEnabled) clickNextBind(e);
return false;
} else if (e.keyCode == 37 && slider.settings.mode != 'vertical') {
if (slider.settings.keyboardEnabled) clickPrevBind(e);
return false;
} else if (e.keyCode == 40 && slider.settings.mode != 'horizontal') {
if (slider.settings.keyboardEnabled) clickNextBind(e);
return false;
} else if (e.keyCode == 38 && slider.settings.mode != 'horizontal') {
if (slider.settings.keyboardEnabled) clickPrevBind(e);
return false;
}
});
}
/**
* ===================================================================================
* = PUBLIC FUNCTIONS
Expand Down Expand Up @@ -1306,6 +1329,14 @@
init();
}

/**
* Toggle keyboard navigation on/off. You can force by sending a boolean parameter (true to enable, false to disable)
*/
el.toggleKeyboard = function(shouldEnable){
if(!slider.initialized) return;
slider.settings.keyboardEnabled = (shouldEnable == undefined) ? !slider.settings.keyboardEnabled : shouldEnable;
}

init();

// returns the current jQuery object
Expand Down