Skip to content

Add question part status to AssignmentProgressDTO #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: redesign-2024
Choose a base branch
from

Conversation

mwtrew
Copy link
Contributor

@mwtrew mwtrew commented May 29, 2025

API changes for isaacphysics/isaac-react-app#1489.

I decided to just add this to the existing DTO and endpoint, since it's used in the same place as the other data. There was also some discussion around refactoring assignment progress so the CSV generation uses the same logic, which I think is possible and a good idea, but I'll do that separately to avoid blocking the above PR.

@mwtrew mwtrew marked this pull request as ready for review May 29, 2025 15:43
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 46.51163% with 23 lines in your changes missing coverage. Please review.

Project coverage is 35.89%. Comparing base (46e4a67) to head (973a68b).
Report is 2 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
.../cl/dtg/isaac/api/managers/UserAttemptManager.java 47.05% 7 Missing and 2 partials ⚠️
.../ac/cam/cl/dtg/isaac/api/managers/GameManager.java 20.00% 6 Missing and 2 partials ⚠️
...ac/cam/cl/dtg/isaac/dto/AssignmentProgressDTO.java 50.00% 4 Missing ⚠️
...ac/cam/cl/dtg/segue/api/managers/GroupManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           redesign-2024     #697      +/-   ##
=================================================
+ Coverage          35.87%   35.89%   +0.01%     
=================================================
  Files                528      528              
  Lines              23490    23500      +10     
  Branches            2851     2853       +2     
=================================================
+ Hits                8427     8435       +8     
  Misses             14201    14201              
- Partials             862      864       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants