Skip to content

Sign in with Microsoft #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sign in with Microsoft #698

wants to merge 7 commits into from

Conversation

barna-isaac
Copy link
Contributor

This is still a work in progress. I've opened a PR because I wanted to see if the tests pass.


Pull Request Check List

  • Unit Tests & Regression Tests Added (Optional)
  • Removed Unnecessary Logs/System.Outs/Comments/TODOs
  • Added enough Logging to monitor expected behaviour change
  • Security - Injection - everything run by an interpreter (SQL, OS...) is either validated or escaped
  • Security - Data Exposure - PII is not stored or sent unencrypted
  • Security - Data Exposure - Test any altered or created endpoints using swagger
  • Security - Access Control - Check authorisation on every new endpoint
  • Security - New dependency - configured sensibly not relying on defaults
  • Security - New dependency - Searched for any know vulnerabilities
  • Security - New dependency - Signed up team to mailing list
  • Security - New dependency - Added to dependency list
  • DB schema changes - postgres-rutherford-create-script updated
  • DB schema changes - upgrade script created matching create script
  • Updated Release Procedure & Documentation (& Considered Implications to Previous Versions)
  • Peer-Reviewed

token will only contain this field if it's requested in scopes
this just checks that the token was signed using one of the keys listed
by the key server. still need to validate the token contents.
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 1.33333% with 74 lines in your changes missing coverage. Please review.

Project coverage is 35.76%. Comparing base (57e4f2c) to head (06d15db).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../cam/cl/dtg/segue/auth/MicrosoftAuthenticator.java 0.00% 69 Missing ⚠️
...e/configuration/SegueGuiceConfigurationModule.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   35.87%   35.76%   -0.12%     
==========================================
  Files         528      529       +1     
  Lines       23487    23561      +74     
  Branches     2850     2855       +5     
==========================================
  Hits         8427     8427              
- Misses      14198    14272      +74     
  Partials      862      862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant