Confirmation email not correct

[hjp22]

Event: https://isaacphysics.org/events/cpd08122017cambridge

logged in as ***@isaacphysics.org (teacher account)
booked a place
confirmation email received - correct title - but content was a .ics file, not the content as in the email template:
https://editor.isaacphysics.org/#!/edit/master/content/email_templates/email_event_booking_confirmed.json

A successful booking was made on 18th July, with the booking confirmation email being received successfully. So something has changed since then to break it.

[mlt47]

Currently looking into this.

For reference, Exception in the stagin API:
java.lang.IllegalArgumentException: Email template contains tag that was not provided! - [{{myBookedEventsURL}}, {{myAssignmentsURL}}]

I'm going to see if I can see what could have caused this state.

Hard coding the URLs in the email template could be a temporary fix (unless the text gets escaped to stop the inclusion of HTML tags).

[mlt47]

I think this will be fixed by my latest pull request but we'll need to double check on Dev tomorrow once it's been accepted.

[sacummins]

@hjp22 Could you confirm what email client you used to see this behaviour? I am struggling to reproduce it.

[hjp22]

The confirmation email appears to view correctly in yahoo, and gmail, but not in mozilla thunderbird.

In Yahoo and Gmail the text (from the appropriate email template) is viewed, and there is an event.ics attachment. But yahoo displays an error (see attached)

In thunderbird just the event.ics is displayed, not the email text (see attached)

[hjp22]

Thunderbird is still not displaying the email text...